Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support generic token formats in IdentityPoolCredentials #484

Merged
merged 9 commits into from
Oct 15, 2020
Merged

feat: support generic token formats in IdentityPoolCredentials #484

merged 9 commits into from
Oct 15, 2020

Conversation

lsirac
Copy link
Contributor

@lsirac lsirac commented Oct 7, 2020

We need to support generic formats for IdentityPoolCredentials (text/json). The environments we support use both formats - K8s (file-sourced) returns the token as text, and Azure (url-sourced) returns the token in JSON format.

The credential source now supports a format entry:

"credential_source": {
  "format": {
    "type": "json",
    "subject_token_field_name": "subject_token"
  }
}

If no format is provided, we default to text.

@lsirac lsirac requested a review from a team as a code owner October 7, 2020 21:56
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2020
@lsirac lsirac requested a review from chingor13 October 7, 2020 23:44
@elharo elharo requested a review from silvolu October 8, 2020 18:38
elharo
elharo previously requested changes Oct 8, 2020
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs an issue with a much more detailed description of why this is needed.

@chingor13
Copy link
Contributor

@elharo All these PRs into the 3pi feature branch are for go/guac-3pi-java

@lsirac
Copy link
Contributor Author

lsirac commented Oct 8, 2020

@elharo I added some more info in the description. The spec (go/guac-3pi) was updated to allow generic formats after we realized we'd need it. b/168918010 has more info.

@elharo
Copy link
Contributor

elharo commented Oct 8, 2020

Since this is open source can we put that info in a public issue?

@lsirac lsirac requested a review from elharo October 9, 2020 21:37
@chingor13 chingor13 dismissed elharo’s stale review October 15, 2020 07:39

Will have separate final review for 3pi

@chingor13 chingor13 merged commit 4666949 into googleapis:3pi Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants