-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support generic token formats in IdentityPoolCredentials #484
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs an issue with a much more detailed description of why this is needed.
@elharo All these PRs into the 3pi feature branch are for go/guac-3pi-java |
@elharo I added some more info in the description. The spec (go/guac-3pi) was updated to allow generic formats after we realized we'd need it. b/168918010 has more info. |
oauth2_http/java/com/google/auth/oauth2/IdentityPoolCredentials.java
Outdated
Show resolved
Hide resolved
Since this is open source can we put that info in a public issue? |
oauth2_http/java/com/google/auth/oauth2/IdentityPoolCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/IdentityPoolCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/IdentityPoolCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/IdentityPoolCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/IdentityPoolCredentials.java
Outdated
Show resolved
Hide resolved
Will have separate final review for 3pi
We need to support generic formats for
IdentityPoolCredentials
(text/json). The environments we support use both formats - K8s (file-sourced) returns the token as text, and Azure (url-sourced) returns the token in JSON format.The credential source now supports a
format
entry:If no format is provided, we default to text.