Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add quota project ID to requestMetadata if present #495

Merged
merged 1 commit into from
Oct 15, 2020
Merged

feat: add quota project ID to requestMetadata if present #495

merged 1 commit into from
Oct 15, 2020

Conversation

lsirac
Copy link
Contributor

@lsirac lsirac commented Oct 15, 2020

This PR does the following:

  • Adds quota project ID to requestMetadata when present
  • Removes use of Truth & adds missing tests for AwsCredentials in ExternalAccountCredentialsTest

@lsirac lsirac requested a review from a team as a code owner October 15, 2020 21:36
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2020
@lsirac lsirac requested a review from chingor13 October 15, 2020 21:42
@elharo elharo requested a review from silvolu October 15, 2020 21:43
@chingor13 chingor13 merged commit dc16550 into googleapis:3pi Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo approved these changes

@chingor13 chingor13 chingor13 approved these changes

@silvolu silvolu Awaiting requested review from silvolu

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lsirac @chingor13 @elharo