Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds external account credentials to ADC #500

Merged
merged 1 commit into from
Oct 21, 2020
Merged

feat: adds external account credentials to ADC #500

merged 1 commit into from
Oct 21, 2020

Conversation

lsirac
Copy link
Contributor

@lsirac lsirac commented Oct 20, 2020

No description provided.

@lsirac lsirac requested a review from a team as a code owner October 20, 2020 21:12
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 20, 2020
@lsirac lsirac requested a review from chingor13 October 20, 2020 21:16
@elharo elharo requested a review from silvolu October 20, 2020 21:23
silvolu
silvolu approved these changes Oct 20, 2020
View reviewed changes
Copy link

@silvolu silvolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chingor13 chingor13 merged commit 124c77c into googleapis:3pi Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvolu silvolu silvolu approved these changes

@chingor13 chingor13 chingor13 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lsirac @chingor13 @silvolu