Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updates AWS credential source #520

Merged
merged 7 commits into from
Dec 15, 2020
Merged

fix: updates AWS credential source #520

merged 7 commits into from
Dec 15, 2020

Conversation

lsirac
Copy link
Contributor

@lsirac lsirac commented Dec 12, 2020

  • Makes the region_url and url fields optional for the AWS credential source.
  • Adds environment ID parsing to detect if breaking changes were introduced.

@lsirac lsirac requested a review from a team as a code owner December 12, 2020 00:17
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 12, 2020
elharo
elharo reviewed Dec 12, 2020
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions; nothing substantive

oauth2_http/java/com/google/auth/oauth2/AwsCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/AwsCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/AwsCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/AwsCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/AwsCredentials.java Outdated Show resolved Hide resolved
@googleapis googleapis deleted a comment from generated-files-bot bot Dec 14, 2020
@codecov
Copy link

codecov bot commented Dec 14, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (3pi@478f33b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             3pi     #520   +/-   ##
======================================
  Coverage       ?   83.17%           
  Complexity     ?      553           
======================================
  Files          ?       38           
  Lines          ?     2591           
  Branches       ?      267           
======================================
  Hits           ?     2155           
  Misses         ?      300           
  Partials       ?      136

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 478f33b...f5adc8c. Read the comment docs.

@chingor13 chingor13 merged commit 3769b90 into googleapis:3pi Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo left review comments

@chingor13 chingor13 chingor13 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lsirac @chingor13 @elharo