-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add impersonation credentials to ADC #613
Merged
Merged
Changes from 29 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
887c67d
ADC can load impersonation credentials
liuchaoren f98b61c
Add tests for new features in ImpersonationCredentials
liuchaoren 9f805fb
Merge remote-tracking branch 'upstream/master'
liuchaoren ebeba8b
Add tests for GoogleCredentials
liuchaoren 33f6db0
Fix linter errors
liuchaoren 8b38844
Fix linter errors in ImpersonatedCredentialsTest
liuchaoren 3a98164
Fix issues after receiving comments
liuchaoren ea3d14a
Merge remote-tracking branch 'upstream/master'
liuchaoren 815e39b
Fix lint errors
liuchaoren 0ee39aa
Handle ClassCastException in fromJson
liuchaoren 35b347a
Fix lint errors
liuchaoren 56ed2bb
minor refactoring
liuchaoren a36da60
fix doc strings
liuchaoren 1b3bcd6
fix lint errors
liuchaoren 685ea43
delegates can be missing from the json file
liuchaoren 3a20de4
Mark test using @Test()
liuchaoren 3ac3809
Merge remote-tracking branch 'upstream/master'
liuchaoren e3f4a66
Remove redundant methods and handle exceptions
liuchaoren 097245e
add an empty file
liuchaoren 9a428d7
remove an empty file
liuchaoren 2febd2a
Fix docstring and move one variable to inner scope.
liuchaoren 3402664
Merge branch 'master' into master
elharo eee39af
Merge branch 'master' into master
elharo b2751ae
Merge remote-tracking branch 'upstream/master'
liuchaoren 8420528
Refactor ImpersonatedCredentialsTest
liuchaoren 51525ab
Merge branch 'master' of github.com:liuchaoren/google-auth-library-java
liuchaoren d34dae2
Reformat the ImpersonatedCredentialsTest
liuchaoren 4ea84e9
Remove redundant checks in tests
liuchaoren 55a0c61
Use VisibleForTesting annotation to limit visibility
liuchaoren 2884531
Merge branch 'master' into master
elharo 35206dc
Merge branch 'master' into master
elharo 6ea5150
Merge branch 'master' into master
elharo b5340d0
Merge branch 'master' into master
elharo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name doesn't quite fit. Create tends t be a factory method. This is more of an
is
method. Is this new in this PR?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is not invented in this PR. It is defined in the base class 'GoogleCredentials' which is overridden by its subclasses. I think it uses "create" in its name because of its relationship with the createScoped method.
google-auth-library-java/oauth2_http/java/com/google/auth/oauth2/GoogleCredentials.java
Line 218 in 292e81a