Skip to content

Commit

Permalink
chore(pubsub): Remove TODO that is 7 years old and on which no action…
Browse files Browse the repository at this point in the history
… has been taken (#9239)

* fix(pubsub): set x-goog-request-params for streaming pull request

* chore(pubsub): Remove TODO that is 7 years old and on which no action has been taken
  • Loading branch information
kamalaboulhosn authored Jan 19, 2024
1 parent 2dd8b3c commit 1cf8cf1
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion pubsub/topic.go
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,6 @@ func (t *Topic) Publish(ctx context.Context, msg *Message) *PublishResult {
t.initBundler()
t.mu.RLock()
defer t.mu.RUnlock()
// TODO(aboulhosn) [from bcmills] consider changing the semantics of bundler to perform this logic so we don't have to do it here
if t.stopped {
ipubsub.SetPublishResult(r, "", ErrTopicStopped)
return r
Expand Down

0 comments on commit 1cf8cf1

Please sign in to comment.