feat(spanner): Add ReadRowWithOptions method #5240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuheiktgw
force-pushed
the
spanner_read_row_with_options
branch
from
96afde1 to
1605b95
Compare
|
Thanks @shuheiktgw for creating the PR, you can add test by referring to this test https://github.com/googleapis/google-cloud-go/blob/main/spanner/client_test.go#L2839 |
shuheiktgw
force-pushed
the
spanner_read_row_with_options
branch
from
b81a887 to
8ad7136
Compare
|
@rahul2393 thanks for pointing it out! I've added a test for the ReadRowWithOptions so would you review the PR please? 🙏 |
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are no ways users can provide ReadOptions to the ReadRow method. It would be great if we have a method for that purpose so I've added a new method called
ReadRowWithOptions. I could not find tests for the ReadRow method so would you guide me on where to add tests for the new method? Thank you!