Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging): fix proto copy #9420

Merged
merged 3 commits into from
Oct 10, 2019
Merged

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Oct 7, 2019

Logging's synth.py wasn't moving the protos over to the right place. It looks like the 'correct' set were getting copied into a deeper directory.

This PR also adds toctrees so the v1 and v2 docs are split.

See the generated docs here.

There's a new type google.cloud.logging_v2.types.BigQueryOptions that the Logging team was asking for. Do I need to modify the v1 client to make it available there?

@busunkim96 busunkim96 added the api: logging Issues related to the Cloud Logging API. label Oct 7, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2019
@busunkim96 busunkim96 requested review from crwilcox and tseaver and removed request for crwilcox October 7, 2019 21:29
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't note these issues inline:

  • Shouldn't the logging/google/cloud/logging_v2/proto/cloud/logging_v2/proto/ directory be removed altogether?
  • Why does the PR delete logging/google/cloud/logging_v2/proto/log_entry.proto / logging/google/cloud/logging_v2/proto/log_severity.proto / logging/google/cloud/logging_v2/proto/logging.proto logging/google/cloud/logging_v2/proto/logging_config.proto / logging/google/cloud/logging_v2/proto/logging_metrics.proto? That is where they are supposed to be, I think, and we are retaining the equivalent _pb2.py files.

@busunkim96
Copy link
Contributor Author

Thank you for the review!

Shouldn't the logging/google/cloud/logging_v2/proto/cloud/logging_v2/proto/ directory be removed altogether?

It's gone as far as I can tell.

Why does the PR delete logging/google/cloud/logging_v2/proto/log_entry.proto / logging/google/cloud/logging_v2/proto/log_severity.proto / logging/google/cloud/logging_v2/proto/logging.proto logging/google/cloud/logging_v2/proto/logging_config.proto / logging/google/cloud/logging_v2/proto/logging_metrics.proto? That is where they are supposed to be, I think, and we are retaining the equivalent _pb2.py files.

Re-added.

@busunkim96 busunkim96 requested a review from tseaver October 8, 2019 23:38
@tseaver
Copy link
Contributor

tseaver commented Oct 9, 2019

@busunkim96

Shouldn't the logging/google/cloud/logging_v2/proto/cloud/logging_v2/proto/ directory be removed altogether?

It's gone as far as I can tell.

It still contains all the _pb2.py files, as well as __init__py. Oops, that is the directory which is supposed to contain those files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants