-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(logging): fix proto copy #9420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't note these issues inline:
- Shouldn't the
logging/google/cloud/logging_v2/proto/cloud/logging_v2/proto/
directory be removed altogether? - Why does the PR delete
logging/google/cloud/logging_v2/proto/log_entry.proto
/logging/google/cloud/logging_v2/proto/log_severity.proto
/logging/google/cloud/logging_v2/proto/logging.proto
logging/google/cloud/logging_v2/proto/logging_config.proto
/logging/google/cloud/logging_v2/proto/logging_metrics.proto
? That is where they are supposed to be, I think, and we are retaining the equivalent_pb2.py
files.
Thank you for the review!
It's gone as far as I can tell.
Re-added. |
|
Logging's synth.py wasn't moving the protos over to the right place. It looks like the 'correct' set were getting copied into a deeper directory.
This PR also adds toctrees so the v1 and v2 docs are split.
See the generated docs here.
There's a new type
google.cloud.logging_v2.types.BigQueryOptions
that the Logging team was asking for. Do I need to modify the v1 client to make it available there?