Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): add 'ARCHIVE' storage class #9533

Merged
merged 5 commits into from
Jan 2, 2020
Merged

feat(storage): add 'ARCHIVE' storage class #9533

merged 5 commits into from
Jan 2, 2020

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 24, 2019

Closes #9532.

@tseaver tseaver added the api: storage Issues related to the Cloud Storage API. label Oct 24, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 24, 2019
@frankyn frankyn requested a review from tritone October 24, 2019 17:44
tritone
tritone reviewed Oct 25, 2019
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise looks good to me pending approval from the language owner. Let's also wait to merge this until the feature is no longer behind a flag (will be a couple weeks).

storage/google/cloud/storage/constants.py Outdated Show resolved Hide resolved
@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 25, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Oct 25, 2019

@tritone, @frankyn, @crwilcox Please approve when the feature is released on the back end.

@tseaver tseaver added the status: blocked Resolving the issue is dependent on other work. label Oct 25, 2019
tritone
tritone approved these changes Dec 27, 2019
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: we're now good to merge this with a plan to release the changes between 1/2 and 1/8 (once the release freeze has ended). Let me know if there's any issue with this timeline!

@tritone
Copy link
Contributor

tritone commented Dec 27, 2019

Update: we're now good to merge this with a plan to release the changes between 1/2 and 1/8 (once the release freeze has ended). Let me know if there's any issue with this timeline!

... also, it looks like we still need approval from a repo owner (@frankyn or @crwilcox ) as well as resolution of the Kokoro failure for Cloud Build (perhaps this just requires a rebase/rerun?).

@crwilcox crwilcox added kokoro:run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work. labels Jan 2, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 2, 2020
@crwilcox
Copy link
Contributor

crwilcox commented Jan 2, 2020

CI is looking good (ignore cloud build failure). Merging.

@crwilcox crwilcox merged commit ac544b1 into googleapis:master Jan 2, 2020
This was referenced Jan 29, 2020
Merged
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

@crwilcox crwilcox crwilcox approved these changes

@frankyn frankyn Awaiting requested review from frankyn

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storage: Add support for Archive storage class
5 participants
@tseaver @tritone @crwilcox @googlebot @yoshi-kokoro