Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigtable-admin-v2): Provide GcRule convenience constructors, and warn if more than one field is set #28210

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(bigtable-admin-v2): Provide GcRule convenience constructors, and warn if more than one field is set #28210

wants to merge 1 commit into from

Conversation

dazuma
Copy link
Member

@dazuma dazuma commented Jan 9, 2025 •
edited
Loading

Extra features for GcRule:

  • Created convenience factory methods for the various types of GcRule.
  • Setting a GcRule field when another is already set, now emits a warning. (The behavior remains the same: the earlier field is automatically cleared, following the normal behavior of a oneof.)

@dazuma dazuma force-pushed the pr/bigtable-oneof branch from 2f7bb0f to 5f99956 Compare January 15, 2025 02:34
@dazuma dazuma marked this pull request as ready for review January 15, 2025 21:39
@dazuma dazuma requested review from yoshi-approver and a team as code owners January 15, 2025 21:39
@dazuma dazuma requested a review from aandreassa January 15, 2025 21:39
aandreassa
aandreassa approved these changes Jan 16, 2025
View reviewed changes
...e-cloud-bigtable-admin-v2/lib/google/cloud/bigtable/admin/v2/bigtable_table_admin/helpers.rb
@@ -0,0 +1,110 @@
# frozen_string_literal: true

# Copyright 2024 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2025 here & others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aandreassa aandreassa aandreassa approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dazuma @aandreassa