Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement chunkedDownload and refactor direct downloads. #1990

Merged
merged 9 commits into from
May 4, 2023
Merged

feat: Implement chunkedDownload and refactor direct downloads. #1990

merged 9 commits into from
May 4, 2023

Conversation

sydney-munro
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@sydney-munro sydney-munro requested a review from a team as a code owner April 20, 2023 16:44
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/java-storage API. labels Apr 20, 2023
BenWhitehead
BenWhitehead approved these changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

After merging this branch, can you also merge main up to feat/transfer-manager it's been a bit since we sync'd.

@sydney-munro sydney-munro merged commit b99a67d into feat/transfer-manager May 4, 2023
@sydney-munro sydney-munro deleted the chunking branch May 4, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/java-storage API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sydney-munro @BenWhitehead