Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to re-enable iam#testPermissions #429

Merged
merged 9 commits into from
Oct 15, 2018
Merged

Conversation

frankyn
Copy link
Contributor

@frankyn frankyn commented Oct 5, 2018

Fixes #393

Fix should be in prod. PR is to re-enable skipped test.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 5, 2018
@ghost ghost assigned frankyn Oct 5, 2018
@ghost ghost assigned JustinBeckwith Oct 8, 2018
@JustinBeckwith
Copy link
Contributor

👋 thanks @frankyn! Can you run npm run fix on this to get the linty in check?

@frankyn
Copy link
Contributor Author

frankyn commented Oct 8, 2018

Sure! Is this not blocked by system tests as well?

@JustinBeckwith
Copy link
Contributor

Well hey, one step at a time 🤣 @kinwa91 is on fixing the system tests as we speak.

@frankyn
Copy link
Contributor Author

frankyn commented Oct 8, 2018

😸 lol, I'm a curious cat! Addressed lint issue.

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 9, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 9, 2018
@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 11, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 11, 2018
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 15, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 15, 2018
@JustinBeckwith JustinBeckwith merged commit f364346 into master Oct 15, 2018
@frankyn frankyn deleted the enable-test-iam-test branch October 15, 2018 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants