Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clarify in docs, the meaning of ASIA and coldline #632

Merged
merged 2 commits into from
Mar 26, 2019
Merged

docs: clarify in docs, the meaning of ASIA and coldline #632

merged 2 commits into from
Mar 26, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Mar 15, 2019

When @laylasells and I were walking through these code examples for the first time, we found the magic variables ASIA and coldline somewhat magical 🌠; this pull request adds documentation clarifying the meaning of these values.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@bcoe bcoe added the type: docs Improvement to the documentation for an API. label Mar 15, 2019
@bcoe bcoe requested a review from JustinBeckwith March 15, 2019 18:20
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 15, 2019
callmehiphop
callmehiphop approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@callmehiphop callmehiphop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

magic

@JustinBeckwith JustinBeckwith added the automerge Merge the pull request once unit tests and other checks pass. label Mar 15, 2019
@codecov
Copy link

codecov bot commented Mar 15, 2019 •
edited
Loading

Codecov Report

Merging #632 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #632   +/-   ##
=======================================
  Coverage   97.94%   97.94%           
=======================================
  Files           9        9           
  Lines         874      874           
  Branches       99       99           
=======================================
  Hits          856      856           
  Misses          9        9           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45bb622...224eb2c. Read the comment docs.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Mar 22, 2019
@callmehiphop callmehiphop merged commit 519ba1b into master Mar 26, 2019
@stephenplusplus stephenplusplus deleted the clarify-bucket-create-docs branch March 26, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callmehiphop callmehiphop callmehiphop approved these changes

@JustinBeckwith JustinBeckwith Awaiting requested review from JustinBeckwith

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bcoe @callmehiphop @JustinBeckwith @googlebot @yoshi-automation