Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade to newest version of @google-cloud/common #657

Merged
merged 3 commits into from
Apr 3, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Apr 2, 2019

With the goal of getting master passing, pulls in @types/[email protected], as 11.13.0 is currently breaking the build.

This PR brings in this breaking change which retires the configurable request object (unfortunately this didn't address the error on master, because other dependencies brought in @types/[email protected].

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 2, 2019
Copy link
Contributor

@callmehiphop callmehiphop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a npm run fix

@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #657 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #657      +/-   ##
==========================================
- Coverage   97.94%   97.92%   -0.02%     
==========================================
  Files           9        9              
  Lines         874      869       -5     
  Branches       99       99              
==========================================
- Hits          856      851       -5     
  Misses          9        9              
  Partials        9        9
Impacted Files Coverage Δ
src/bucket.ts 95.74% <ø> (-0.02%) ⬇️
src/channel.ts 100% <ø> (ø) ⬆️
src/notification.ts 100% <ø> (ø) ⬆️
src/storage.ts 98.33% <ø> (-0.03%) ⬇️
src/file.ts 98.64% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92332dd...ce4e642. Read the comment docs.

@callmehiphop callmehiphop merged commit c44f70d into master Apr 3, 2019
@stephenplusplus stephenplusplus deleted the upgrade-nodejs-common branch November 26, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants