-
Notifications
You must be signed in to change notification settings - Fork 431
Conversation
I'm fine with removing both locked_file/multistore_file if a suitable alternative is provided. The requirement is to safely use a single credential across multiple processes and threads. If we can find a better cross-platform way to do that, I'm happy to port gsutil over (other incompatibilities notwithstanding). |
I'll start a separate issue for that, thanks, @thobrla. |
instance._locked = True | ||
self.assertTrue(instance.is_locked()) | ||
|
||
def test_is_locked(self): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
LGTM mostly |
f540215
to
f931ce3
Compare
Updated, should address most of your comments. Thanks for the review. I have no idea what it is about this library but I just end up writing sloppy tests. :| |
LGTM more mostly |
Any qualms with merging this? Should we get @nathanielmanistaatgoogle? I'm just past caring on this one and would rather push for its removal if we can get gcloud cli and gsutil to play along. |
Ha sorry my last comment was meant to be a "go-ahead and merge" LGTM |
Ha. Fair enough. I'm still open to suggestions on testing the platform-specific stuff (mocks?) provided we don't vote it off the island. |
Added tests for contrib.locked_file.
Towards #212
This module beastly. It's only user is
multistore_file
and honestly I would be in favor of outright removing this and that from the library altogether.These tests do not cover the platform-specific opener classes - I'd really like to hear some ideas on how to test those.