Skip to content
This repository has been archived by the owner on Jan 18, 2025. It is now read-only.

Replacing now() with utcnow() in device info code. #488

Merged
merged 1 commit into from
May 20, 2016
Merged

Replacing now() with utcnow() in device info code. #488

merged 1 commit into from
May 20, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Apr 7, 2016

This change was discussed in #485.

@nathanielmanistaatgoogle
Copy link
Contributor

Commit looks good; merge when test results land.

@dhermes
Copy link
Contributor Author

dhermes commented Apr 7, 2016

So we aren't worried about breakage?

@nathanielmanistaatgoogle
Copy link
Contributor

I'm a little worried, but not as much as I would be had the library ever documented the attribute as being in local time.

Do we feel that the value is worth the cost?

Should this be put on ice and rolled into whatever it is that motivates a more dramatic breaking change?

@dhermes
Copy link
Contributor Author

dhermes commented Apr 7, 2016

I don't mind if it gets put on ice but have no desire to be in charge of

  • Keeping track of when it is appropriate to merge this
  • Keeping this PR up to date with the library as it gets updated

@theacodes
Copy link
Contributor

I'm in favor of merging this to release with 2.1.0

@nathanielmanistaatgoogle nathanielmanistaatgoogle merged commit e54e289 into googleapis:master May 20, 2016
@dhermes dhermes deleted the swap-to-utcnow branch May 20, 2016 15:45
@theacodes theacodes mentioned this pull request May 20, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @nathanielmanistaatgoogle @theacodes @googlebot