This repository has been archived by the owner on Jan 18, 2025. It is now read-only.
Use transport.request in tests. #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhermes
force-pushed
the
use-transport-request-in-tests
branch
from
4b37332 to
930149b
Compare
| import unittest2 | ||
|
|
||
| from oauth2client import _helpers | ||
| from oauth2client import client | ||
| from oauth2client import crypt | ||
| from oauth2client import file | ||
| from oauth2client import file as file_mod |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks nearly good to me. |
In the process - "spring clean" the modules that were touched - use HttpMock when HttpMockSequence not needed - add some verifications on new HttpMock's
| import unittest2 | ||
|
|
||
| from oauth2client import _helpers | ||
| from oauth2client import client | ||
| from oauth2client import file | ||
| from .http_mock import HttpMockSequence | ||
| from oauth2client import file as file_mod |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
force-pushed
the
use-transport-request-in-tests
branch
from
930149b to
1a0c4db
Compare
|
@nathanielmanistaatgoogle I made your |
|
We're all good here. 👍 |
This was referenced Sep 15, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process
HttpMockwhenHttpMockSequencenot neededHttpMock's