-
Notifications
You must be signed in to change notification settings - Fork 431
Try to revoke token with POST when getting a 405 #662
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
Hi @LiraNuna! This change looks good, but you'll need to add another test to cover this so that travis passes. |
@jonparrott Thanks for your response! Just noticed the failure as well - I'll get the tests soon. |
Sounds good, just ping me when you're ready. (Also, small world - I remember you from NDS dev stuff. 😄 ) |
The OAuth spec does not specify the HTTP verb explicitly but it does hint that POST is the correct verb. When using the client library with other OAuth services that implement revocation token via a POST, revoking the token will fail. This commit adds the ability to re-try the revocation process if we get a 405 with the POST verb.
@jonparrott Tests fixed - I had to reshuffle stuff around to get the desired behavior correctly. (Small world!) |
Thanks for the contribution, @LiraNuna! |
@jonparrott how soon should I expect this to show up on PyPI? I've noticed the current code is a bit different than |
I'm not sure. |
The OAuth spec does not specify the HTTP verb explicitly but it does hint that POST is the correct verb.
When using the client library with other OAuth services that implement revocation token via a POST, revoking the token will fail.
This commit adds the ability to re-try the revocation process if we get a 405 with the POST verb.