-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support data_governance_type #1708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth adding the new field to an existing system/integration test related to routines, or are there extensive dependencies here to properly setup masking?
|
||
@data_governance_type.setter | ||
def data_governance_type(self, value): | ||
if value is not None and value not in self._DATA_GOVERNANCE_TYPE: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally we try to avoid this kind of setter enforcement in the client library itself, as the library may not be aware of all valid values. Allow the methods to raise errors if there's issues (e.g at routine creation/update/etc).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is really good to know! I will only check for type instead.
Data governance feels like a new CUJ that is not covered by the current system tests, with a unique set of requirements for the routine itself (e.g., can have only one argument, input and output must be of the same type, etc.). So I added a test case for it. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1707 🦕