chore!: deprecate AppEngineHandler and ContainerEngineHandler #298
Conversation
product-auto-label
bot
added
the
api: logging
google-cla
bot
added
the
cla: yes
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
…-logging into deprecate_old_handlers
daniel-sanche
changed the title
daniel-sanche
changed the title
…-logging into deprecate_old_handlers
| :class:`~google.cloud.logging.handlers.app_engine.AppEngineHandler`, which is | ||
| recommended when running on the Google App Engine Flexible vanilla runtimes | ||
| (i.e. your app.yaml contains ``runtime: python``), and |
There was a problem hiding this comment.
We should mark the classes as deprecated: update the docs to mention that they are not returned anymore and that new classes replace them. Folks who have existing code using 2.* library release should have a path forward that explains how to upgrade to 3.0.0
There was a problem hiding this comment.
My plan was to go through and update the docs at the end of the milestone, just in case any docs changes become out of date later (#245)
Do you think that makes sense, or should I try to update the docs along-side changes?
There was a problem hiding this comment.
We can update the docs later. The point here is more about the annotation of the classes.
| @@ -352,9 +350,9 @@ def get_default_handler(self, **kw): | |||
|
|
|||
| if isinstance(monitored_resource, Resource): | |||
There was a problem hiding this comment.
@daniel-sanche is it possible to document the behavior of get_default_handler more thoroughly somewhere, including the default for each environment? I think some users will be initially confused why their logs are showing up in stdout and/or whichever other sinks they might be streaming their stdout logs to
There was a problem hiding this comment.
I added this suggestion to the open issue around updating the docs for v3.
Let me know if you have thoughts about whether docs should be updated along with each change, or as a pass at the end of the milestone
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
closed in favor of #310 |
This is the first PR for the upcoming 3.0.0 release. Removes AppEngineHandler and ContainerEngineHandler in favor of the more generic CloudLoggingHandler (for network logging) and StructuredLogHandler (for standard output JSON logging).
Fixes #202