-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unintended exception omittion #736
Merged
daniel-sanche
merged 5 commits into
googleapis:main
from
shkumagai:fix/unintended-exception-omittion
Sep 25, 2023
Merged
fix: unintended exception omittion #736
daniel-sanche
merged 5 commits into
googleapis:main
from
shkumagai:fix/unintended-exception-omittion
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
Pull request size is small.
api: logging
Issues related to the googleapis/python-logging API.
labels
Mar 30, 2023
shkumagai
force-pushed
the
fix/unintended-exception-omittion
branch
from
April 24, 2023 23:21
f9a54b2
to
6248e5d
Compare
product-auto-label
bot
added
the
stale: old
Pull request is old and needs attention.
label
Apr 29, 2023
product-auto-label
bot
added
stale: extraold
Pull request is critically old and needs prioritization.
and removed
stale: old
Pull request is old and needs attention.
labels
May 29, 2023
parthea
added
kokoro:run
Add this label to force Kokoro to re-run the tests.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Aug 9, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Aug 9, 2023
yoshi-kokoro
removed
kokoro:run
Add this label to force Kokoro to re-run the tests.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Aug 9, 2023
daniel-sanche
added
the
kokoro:run
Add this label to force Kokoro to re-run the tests.
label
Sep 25, 2023
yoshi-kokoro
removed
kokoro:run
Add this label to force Kokoro to re-run the tests.
labels
Sep 25, 2023
daniel-sanche
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Sep 25, 2023
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Sep 25, 2023
daniel-sanche
approved these changes
Sep 25, 2023
thanks for putting this together! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: logging
Issues related to the googleapis/python-logging API.
size: s
Pull request size is small.
stale: extraold
Pull request is critically old and needs prioritization.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I wrote in #735, StructuredLogHander removes exception info from the record object directly to omit traceback in a structured log message (it was fixed in #394).
This affects any log handlers that will be called later than StructuredLogHander.
This PR changes implementation to omit traceback in a log message.
Fixes #735 🦕