Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add sample and sample test for transfer manager #1027

Merged
merged 5 commits into from
May 2, 2023
Merged

docs: add sample and sample test for transfer manager #1027

merged 5 commits into from
May 2, 2023

Conversation

MiaCY
Copy link
Contributor

@MiaCY MiaCY commented Apr 29, 2023

  • Split existing transfer manager samples into different files
  • Refactor sample tests accordingly
  • Add sample for download_blob_as_chunks_concurrently
  • Add sample test for download_blob_as_chunks_concurrently

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Apr 29, 2023 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. labels Apr 29, 2023
@MiaCY MiaCY added the owlbot:run Add this label to trigger the Owlbot post processor. label May 2, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 2, 2023
@MiaCY MiaCY added the owlbot:run Add this label to trigger the Owlbot post processor. label May 2, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 2, 2023
@MiaCY MiaCY marked this pull request as ready for review May 2, 2023 17:07
@MiaCY MiaCY requested review from a team as code owners May 2, 2023 17:07
@MiaCY MiaCY requested a review from parthea May 2, 2023 17:07
andrewsg
andrewsg requested changes May 2, 2023
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

Rather than file names in the format of "storage_something_something_with_transfer_manager.py", let's rename them so they're all in a row alphabetically: in the pattern "storage_transfer_manager_something_something". The directory is very hard to browse, so I think it would be better if they are all in the same place in the directory listing even if it makes the file names sound a bit more mechanical.

samples/snippets/storage_download_all_blobs_with_transfer_manager.py Outdated Show resolved Hide resolved
samples/snippets/storage_download_blob_as_chunks_concurrently.py Outdated Show resolved Hide resolved
@MiaCY MiaCY added the owlbot:run Add this label to trigger the Owlbot post processor. label May 2, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 2, 2023
@MiaCY MiaCY requested a review from andrewsg May 2, 2023 21:36
@andrewsg andrewsg merged commit 4698799 into googleapis:main May 2, 2023
@andrewsg andrewsg changed the title chore: add sample and sample test for transfer manager docs: add sample and sample test for transfer manager May 2, 2023
@release-please release-please bot mentioned this pull request May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

@parthea parthea Awaiting requested review from parthea parthea is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiaCY @andrewsg