fix: extend wait for bucket metadata consistency in system tests #1053
Conversation
product-auto-label
bot
added
size: s
| # clean one each rerun. "unique_name" is unique per test iteration, not | ||
| # per test rerun. | ||
| global ebh_bucket_iteration | ||
| ebh_bucket_iteration += 1 |
There was a problem hiding this comment.
Why not simply use uuid.uuid4().hex[:10] to have unique names without tracking?
There was a problem hiding this comment.
I figured if we need to examine the artifacts or their logs later, having them in order would make it easier to determine which one we're looking for.
There was a problem hiding this comment.
Reviewing the flaky tests related to this caching change, let's also apply await_config_changes_propagate or appropriate retries around bucket metadata patches. Otherwise looks good, thank you!
i.e. https://github.com/googleapis/python-storage/blob/main/tests/system/test_bucket.py#L693-L694
i.e. https://github.com/googleapis/python-storage/blob/main/tests/system/test_bucket.py#L921-L938
Surprisingly this error turned out to be related to the pytest-rerunfailures process and was not the root cause. It's fixed by changing the bucket to not be session-shared.
I'll take a look at this one now. Thanks! |
|
PTAL @cojenco |
andrewsg
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
cojenco
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
meredithslota
added
the
kokoro:force-run
No description provided.