Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: add cloud client samples from python-docs-samples #626

Merged
merged 201 commits into from
Oct 19, 2021
Merged

samples: add cloud client samples from python-docs-samples #626

merged 201 commits into from
Oct 19, 2021

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Oct 18, 2021 •
edited
Loading

Pull samples in from https://github.com/GoogleCloudPlatform/python-docs-samples/tree/master/storage/cloud-client

  • Add noxfile.py
  • Remove invalid/unused region tag in notification_polling.py
    ( The github code demo is directly linked here. The region tags are invalid and are not registered code samples.)
  • TODO in a separate PR Update snippets README #627

Jon Wayne Parrott and others added 30 commits July 13, 2016 10:15
Renaming storage gcloud samples folder. (#418)
d0e44f4
Add gcloud-based storage usage samples. (#419)
9e4c4e8
Refactor cloud client storage samples. (#421)
625e4da
Add more storage samples for the cloud client libraries. (#432)
677d2cf
@dpebot
Auto-update dependencies. (#456)
667c262
Fix import order lint errors
a9d1ebc 
Change-Id: Ieaf7237fc6f925daec46a07d2e81a452b841198a
Add storage acl samples
1460861 
Change-Id: Ib44f9bb42bf0c0607e64905a26369f06ea5fb231
Address review comments
430c4bb 
Change-Id: I94973a839f38ef3d1ec657c3c79f666eca56728b
Fix lint issue
79aa1f5 
Change-Id: Ie9cf585303931f200a763d691906ad56221105fd
@dpebot
Auto-update dependencies. (#540)
93b7b07
@dpebot
Auto-update dependencies. (#542)
2a0b60a
Move to google-cloud (#544)
deff097
@jmdobry
Add new "quickstart" samples (#547)
197a0d5
Quickstart tests (#569)
a6edaff 
* Add tests for quickstarts
* Update secrets
Add basic readme generator (#580)
73df899
Generate readmes for most service samples (#599)
2e3f667
Update samples to support latest Google Cloud Python (#656)
8141e0a
@ryanmats
Edited upload/download to perform encryption properly (#667)
3510b2d
@ryanmats @dpebot
Storage Encryption Key Rotation Sample using Veneer + Tests (#672)
3f9071f
@dpebot
Auto-update dependencies. (#715)
0f5037b
@BrandonY
Adds storage Pub/Sub notification polling tutorial (#875)
003648d
@dpebot
Remove cloud config fixture (#887)
b17b759 
* Remove cloud config fixture

* Fix client secrets

* Fix bigtable instance
@dpebot
Auto-update dependencies. (#914)
21f7db6 
* Auto-update dependencies.

* xfail the error reporting test

* Fix lint
Re-generate all readmes
fba8c2d
Add bucket-level IAM samples (#919)
afd5ed6 
* Add bucket-level IAM samples
* Address review comments
@dpebot
Auto-update dependencies. (#927)
be5c929
@waprin
Fix README rst links (#962)
e7b7ccd 
* Fix README rst links

* Update all READMEs
@dpebot
Auto-update dependencies. (#1004)
299847e 
* Auto-update dependencies.

* Fix natural language samples

* Fix pubsub iam samples

* Fix language samples

* Fix bigquery samples
Add bucket label samples (#1045)
8e71bd5
@dpebot
Auto-update dependencies. (#1055)
2dc3106 
* Auto-update dependencies.

* Explicitly use latest bigtable client

Change-Id: Id71e9e768f020730e4ca9514a0d7ebaa794e7d9e

* Revert language update for now

Change-Id: I8867f154e9a5aae00d0047c9caf880e5e8f50c53

* Remove pdb. smh

Change-Id: I5ff905fadc026eebbcd45512d4e76e003e3b2b43
@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 18, 2021
@cojenco cojenco added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 18, 2021
@google-cla
Copy link

google-cla bot commented Oct 18, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 18, 2021
@google-cla
Copy link

google-cla bot commented Oct 18, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Oct 18, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 18, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 18, 2021
@cojenco cojenco mentioned this pull request Oct 18, 2021
Closed
@cojenco cojenco added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 18, 2021
@cojenco cojenco marked this pull request as ready for review October 18, 2021 22:15
@cojenco cojenco requested review from a team as code owners October 18, 2021 22:15
unforced
unforced approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@unforced unforced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to see your graph of total # of lines of code committed after this is approved, haha.

@cojenco cojenco added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 19, 2021
@cojenco cojenco merged commit e08f638 into main Oct 19, 2021
@cojenco cojenco deleted the move-samples branch October 19, 2021 18:45
tseaver
tseaver reviewed Oct 25, 2021
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry I overlooked this PR last week. I only noticed today because of PR #630, which is trying to update the dependency for google-api-python-client.

samples/snippets/acl_test.py

import backoff
from google.cloud import storage
from googleapiclient.errors import HttpError
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a fossil from samples that used googleapiclient. I'm pretty sure that doing backoff / retries around this error is pointless -- nothing else in google-cloud-storage ever raises it (or imports / depends on googleapiclient).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct error class is probably google.api_core.exceptions.GoogleAPIError.

tseaver added a commit that referenced this pull request Oct 25, 2021
@tseaver
tests: replace spurious googleapis exception w/ api_core
4fe23fd 
Closes #630.

See #626 (comment)
@tseaver tseaver mentioned this pull request Oct 25, 2021
Merged
tseaver added a commit that referenced this pull request Oct 25, 2021
@tseaver
tests: replace spurious googleapis exception w/ api_core (#636)
eec54f3 
Closes #630.

See #626 (comment)
@cojenco cojenco mentioned this pull request Oct 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver left review comments

@unforced unforced unforced approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.