Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to disable changelog generation #2007

Open
kettanaito opened this issue Jul 10, 2023 · 7 comments · May be fixed by unjust/release-please#1
Open

Add an option to disable changelog generation #2007

kettanaito opened this issue Jul 10, 2023 · 7 comments · May be fixed by unjust/release-please#1
Assignees
Labels
help wanted We'd love to have community involvement on this issue. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@kettanaito
Copy link

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Is your feature request related to a problem? Please describe.

I'm frustrated that Release Please always generates and commits a CHANGELOG.md file. It is the developer's decision to keep that file or not, and it must not be enforced by this tool. For instance, I find changelog files to be redundant and provide little use to the end consumers of my software. I use GitHub releases as the changelog, which Release Please already fills in using the same content as the changelog.

Describe the solution you'd like

A --disable-changelog boolean flag which, when set to true, skips the changelog generation phase altogether.

Describe alternatives you've considered

  1. Setting changelog-types: "", gets ignored by the tool.
  2. Setting changelog-path to the path ignored in Git. No effect either.
@kettanaito kettanaito added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jul 10, 2023
@unjust
Copy link

unjust commented Jul 22, 2023

I'm using release-please with a monorepo and I prefer one changelog for the entire project, and not for the subprojects.
I've tried "changelog-path": "", "changelog-path": false, in the config.json in order to skip it in subprojects, but its still generated.
also adding CHANGELOG.md to my .gitignore doesnt stop the pull request from adding them, maybe oktokit bypasses the gitignore? 🤷

@chingor13 chingor13 added the help wanted We'd love to have community involvement on this issue. label Jul 25, 2023
@chingor13
Copy link
Contributor

An option to disable changelog generation is feasible, but not something we're planning on implementing. We would welcome a pull request to potentially add the feature.

@kettanaito
Copy link
Author

@chingor13, I'd love to help you ship it. Just, let me know what kind of API you find best to disable changelog generation. I proposed --disable-changelog above, do you have any opinions on that? We can also use --no-changelog, following the --no flags convention for negative expected behaviors.

If we can agree on the API here, I will try to pen a pull request this/next week. Thanks!

@chingor13
Copy link
Contributor

Thanks!

I think we want this as a manifest config option (schema: https://github.com/googleapis/release-please/blob/main/schemas/config.json). The CLI option is an optional inline interface into specifying a manifest config (but we prefer folks configure a manifest config).

As for the naming of the option, I would suggest skip-changelog to match skip-release and skip-snapshot configuration options.

@unjust
Copy link

unjust commented Aug 2, 2023

+1 on the manifest option. It would be nice to be able to skip-change logs on packages in a repo but still keep the overall changelog. I think the manifest would allow this granularity.

@unjust
Copy link

unjust commented Aug 13, 2023

@kettanaito do you have a branch for this work yet ? 👀 need a hand ?

@aabouzaid
Copy link
Contributor

@unjust I see that you already have some WIP ... did you open a PR for it? (or willing to continue working on it?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted We'd love to have community involvement on this issue. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants