-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial release #1
Conversation
Disabling changelogI researched this and found no existing means to disable the I've opened a feature proposal to add it googleapis/release-please#2007. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this! Just have a difference of opinion on maybe exposing an additional first flag, but LGTM otherwise
|
||
## Outputs | ||
|
||
### `report` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between this and the output
option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is not the option you provide to the action but what output the action provides you. In other words, regardless of how you run Artillery as a part of your workflow, you can always access the test run report under ${{ steps[id].outputs.report }}
(a path to the report file on the remote machine).
This is pretty handy as an output because it allows devs to manipulate the report easier, using the standard GitHub Actions' output API. For example, they can upload the report as an artifact or feed it to another step by referencing the output.
Is there a way to default to using the latest Docker image, but allow overrides explicitly? So that users don't have to remember to always include |
@hassy, I will look more into it. So far, the closest thing for a custom action to specify a Docker container is creating a Docker container action. Based on the resources I read, it looks like the container will only be used to run the action (?) but not the entire workflow, so it doesn't act as an override for the job-level I will try to find some examples of this and see if we can use it in any way to make the container setup easier for the users. |
@hassy, I've played around with the Docker GitHub Actions and found a way for us to use our container as a part of our action so the developers don't have to specify it in their workflows anymore. This change also means that we don't keep any dependencies and use an |
chore: try addnab/docker-run-action chore: try local entrypoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Cool to see you ended up with the Docker Container Action after all. Now we know about both ways, so if/when we do ship a NodeJS API, we can revisit this easily if we want 👍
@bernardobridge, exactly! Since the Docker container usage became an implementation detail, we can manage it internally without introducing any breaking changes to the consumers. |
Documenting the new action in here https://github.com/artilleryio/docs/pull/21 |
Users can now adopt Artillery easier in their GitHub workflows by using our action:
Changes
Roadmap
Skip the CHANGELOG generation and treat GitHub Releases as the changelog.