feat(go): add support for bumping a Go version file #1089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
codyoss
added
the
do not merge
codyoss
removed
the
do not merge
bcoe
approved these changes
Nov 8, 2021
bcoe
suggested changes
Nov 8, 2021
| .onCall(0) | ||
| .rejects(Object.assign(Error('not found'), {status: 404})); | ||
| .withArgs('version.go', 'master') | ||
| .resolves(buildFileContent('version.go')); |
There was a problem hiding this comment.
I think it might be worth adding a test case that confirms that a missing version.go is a noop.
There was a problem hiding this comment.
I can add an explicit test if you think that is needed but I showed in a couple of followup commits this is confirmed by current tests:
|
@codyoss we have this huge refactor which I think is pretty much ready to land: https://github.com/chingor13/rp3 @chingor13 should we land this, and merge it into your refactor. Or land your refactor and merge this work into it? |
|
@codyoss okay, refactor is complete, sorry for doing that to you. |
|
Reimplemented in #1112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.