Skip to content
This repository has been archived by the owner on May 29, 2023. It is now read-only.

fix(deps): update dependency @octokit/rest to v16 #87

Merged
merged 3 commits into from
Nov 19, 2018

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 17, 2018

This PR contains the following updates:

Package Type Update Change References
@​octokit/rest dependencies major ^15.15.1 -> ^16.0.0 source

Release Notes

octokit/rest.js

v16.0.1

Compare Source

Bug Fixes
  • typescript: Adding return types (18ac5bf), closes #​1116
  • typescript: Adding the noImplicitAny flag to validate:ts (ef4d35a)
  • typescript: Github.plugin is a static method, not an instance method (01763bf)
  • typescript: include a header object when transforming Content-Type and Content-Length to headers.content-type and headers.content-length (0b9cc37)

Thanks @​mamodom for your great help with these Typescript fixes 💐

v16.0.0

Compare Source

To upgrade to v16, make sure you have the latest v15 release installed first:

npm install @​octokit/[email protected]

Now run the tests and look for DEPRECATED messages in the logs. Once you see no more deprecations, upgrading to v16 should cause no problems.

BREAKING CHANGES
  • all previously deprecated methods have been removed

  • preview headers that are not required to use an API have been removed

  • .gitdata.getTags() has been removed. Use .gitdata.listRefs({namespace: tags}) instead

  • Methods for undocumented endpoints have been removed.

    Instead of client.users.getById({id}) use client.request({method: GET, url: /user/:id, id})
    Instead of client.repos.getById({id}) use client.request({method: GET, url: /repositories/:id, id})

  • octokit.enterprise.* methods have been removed. They will be moved into a plugin like https://github.com/octokit/plugin-scim.js

  • routes: the milestone parameter is no longer validated using a regex as it cannot be derived from octokit/routes

  • travis: dropped support for node 4

  • error.message is no longer a JSON string containing GitHub’s error message. Instead the JSON is parsed internally and error properties are assigned with its value. This is not technically a breaking change but a bug fix, but as this bug was around for a long time and plenty of apps depend on JSON.parse(error.message) to be working, we treat it as a breaking change by way of precaution

  • error.status is now the response status code number. The status text is no longer returned

Features
Bug Fixes
  • routes: remove validation for milestone parameter as it cannot be derived from octokit/routes (4d04d17)
  • only set preview headers required to use the API (1628821)
  • parse JSON from GitHub error messages (dd6306e)
Continuous Integration
  • travis: drop tests in node 4 & 9, test in node 10 (ad8b1e5)

Renovate configuration

📅 Schedule: "after 9am and before 3pm" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


This PR has been generated by Renovate Bot. View repository job log here.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 17, 2018
@renovate
Copy link
Contributor Author

renovate bot commented Nov 19, 2018

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over then you can add the label rebase to this PR and Renovate will reset/recreate it.

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2018
@JustinBeckwith JustinBeckwith merged commit 7f1a5c8 into master Nov 19, 2018
@renovate renovate bot deleted the renovate/octokit-rest-16.x branch November 19, 2018 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants