Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine coupling #37

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Engine coupling #37

merged 1 commit into from
Dec 28, 2024

Conversation

jaytaph
Copy link
Member

@jaytaph jaytaph commented Dec 24, 2024

Coupling the gosub_engine as a dependency to the browser. It should render the loaded html instead of just raw displaying it.

This was referenced Dec 24, 2024
Closed
Closed
@jaytaph jaytaph force-pushed the engine-coupling branch 5 times, most recently from 0174b58 to ed1847d Compare December 24, 2024 18:38
Sharktheone
Sharktheone approved these changes Dec 24, 2024
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@jaytaph jaytaph requested a review from Sharktheone December 28, 2024 13:58
Sharktheone
Sharktheone approved these changes Dec 28, 2024
View reviewed changes
Copy link
Member

@Sharktheone Sharktheone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code will be a lot cleaner with the new EngineInstance but without this looks good.

@jaytaph jaytaph merged commit a036d65 into main Dec 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sharktheone Sharktheone Sharktheone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaytaph @Sharktheone