Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circleci: add go1.21, go1.22, go1.23, and update golangci-lint to v1.60.3 #285

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

thaJeztah
Copy link
Contributor

No description provided.

@thaJeztah
Copy link
Contributor Author

FWIW, one of the linters is deprecated;

WARN The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar.

However changing it to the replacement doesn't help much, because that looks at the go version in go.mod;

WARN [linters_context] copyloopvar: this linter is disabled because the Go version (1.17) of your project is lower than Go 1.22

So I kept the deprecated (but currently still functional) one for now.

Copy link
Member

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I pushed a commit to remove go1.18 and go1.19. I generally remove older versions when I add new ones, and keep it to 4 (or fewer) versions being tested.

@dnephin dnephin merged commit c5dad8f into gotestyourself:main Sep 5, 2024
7 checks passed
@thaJeztah thaJeztah deleted the update_go_versions branch September 5, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants