Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 2.17 #30

Closed
wants to merge 6 commits into from
Closed

Upgrade to 2.17 #30

wants to merge 6 commits into from

Conversation

snewcomer
Copy link

Here is just a start to potentially working towards getting Ember into https://github.com/gothinkster/realworld

.eslintrc.js Outdated
env: {
browser: true
},
rules: {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was wreaking havoc on the test suite. Lmk if this is important to everybody and I can add it back!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, we use this to lint along with prettier.
Please re-implement this and get the test suite passing.

If you need any help you can look here:
https://prettier.io/docs/en/eslint.html

@Alonski
Copy link
Member

Alonski commented Dec 21, 2017

I'll take a look hopefully tomorrow. Can you take a lot at the other pull requests and see if they are satisfactory? I'll merge them if so.

Copy link
Contributor

@jonnii jonnii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, :shipit:

@snewcomer snewcomer mentioned this pull request Dec 24, 2017
Copy link
Member

@Alonski Alonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-implement ESLint + Prettier

.eslintrc.js Outdated
env: {
browser: true
},
rules: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, we use this to lint along with prettier.
Please re-implement this and get the test suite passing.

If you need any help you can look here:
https://prettier.io/docs/en/eslint.html

@jonnii
Copy link
Contributor

jonnii commented Dec 26, 2017

@Alonski i think it's better to use the settings that come out of the box tbh.

@jonnii
Copy link
Contributor

jonnii commented Dec 26, 2017

Actually on second thought I'm ambivalent about this, but it's just another thing that someone who is looking at this repo has to know and install. I personally use the same prettier settings in my own projects.

@Alonski
Copy link
Member

Alonski commented Dec 26, 2017

@jonnii Which settings do you use? I found that for Ember lines can get a bit long and the other is just a preference.
Anyways I want Eslint to lint prettier settings as well

@snewcomer
Copy link
Author

@Alonski my bad...fixed

@snewcomer
Copy link
Author

@Alonski just pinging this again! no rush though :)

@Alonski
Copy link
Member

Alonski commented Dec 31, 2017

Hey, hope I am not being a bummer.
But 2.17.2 came out :)

Could you also update the rest of the npm packages while you are at it?

Using D:\Projects\Fun Stuff\ember-realworld\package.json

 tslint                          4.0.2  →    5.8.0
 typescript                      2.0.0  →    2.6.2
 ember-cli-dependency-checker   ^1.4.0  →   ^2.1.0
 eslint                        ^3.19.0  →  ^4.14.0
 eslint-config-prettier         ^1.7.0  →   ^2.9.0

The following dependencies are satisfied by their declared version range, but the installed versions are behind. You can
 install the latest versions without modifying your package file by using npm update. If you want to update the dependen
cies in your package file anyway, run ncu -a.

 broccoli-asset-rev                     ^2.5.0  →   ^2.6.0
 ember-cli                             ^2.17.0  →  ^2.17.2
 ember-cli-babel                        ^6.6.0  →  ^6.11.0
 ember-cli-eslint                       ^4.2.1  →   ^4.2.3
 ember-cli-htmlbars                     ^2.0.1  →   ^2.0.3
 ember-cli-htmlbars-inline-precompile   ^1.0.0  →   ^1.0.2
 ember-cli-inject-live-reload           ^1.6.1  →   ^1.7.0
 ember-cli-moment-shim                  ^3.1.0  →   ^3.5.0
 ember-cli-qunit                        ^4.1.1  →   ^4.2.1
 ember-data                            ^2.17.0  →  ^2.18.0
 ember-moment                           ^7.3.0  →   ^7.5.0
 ember-resolver                         ^4.1.0  →   ^4.5.0
 ember-route-action-helper              ^2.0.3  →   ^2.0.6
 ember-simple-auth                      ^1.4.1  →   ^1.4.2
 eslint-plugin-prettier                 ^2.0.1  →   ^2.4.0
 loader.js                              ^4.3.0  →   ^4.6.0
 prettier                               ^1.2.2  →   ^1.9.2

Run ncu with -u to upgrade package.json

You can use the npm package: npm-check-updates to get this list

@Alonski
Copy link
Member

Alonski commented Jan 20, 2018

Hey man
Are you planning to update any more or should I merge this in?

@Alonski
Copy link
Member

Alonski commented Aug 5, 2018

Closing this because of #33

@Alonski Alonski closed this Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants