-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to 2.17 #30
Upgrade to 2.17 #30
Conversation
.eslintrc.js
Outdated
env: { | ||
browser: true | ||
}, | ||
rules: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was wreaking havoc on the test suite. Lmk if this is important to everybody and I can add it back!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, we use this to lint along with prettier.
Please re-implement this and get the test suite passing.
If you need any help you can look here:
https://prettier.io/docs/en/eslint.html
I'll take a look hopefully tomorrow. Can you take a lot at the other pull requests and see if they are satisfactory? I'll merge them if so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please re-implement ESLint + Prettier
.eslintrc.js
Outdated
env: { | ||
browser: true | ||
}, | ||
rules: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, we use this to lint along with prettier.
Please re-implement this and get the test suite passing.
If you need any help you can look here:
https://prettier.io/docs/en/eslint.html
@Alonski i think it's better to use the settings that come out of the box tbh. |
Actually on second thought I'm ambivalent about this, but it's just another thing that someone who is looking at this repo has to know and install. I personally use the same prettier settings in my own projects. |
@jonnii Which settings do you use? I found that for Ember lines can get a bit long and the other is just a preference. |
@Alonski my bad...fixed |
@Alonski just pinging this again! no rush though :) |
Hey, hope I am not being a bummer. Could you also update the rest of the npm packages while you are at it?
You can use the npm package: npm-check-updates to get this list |
Hey man |
Closing this because of #33 |
Here is just a start to potentially working towards getting Ember into https://github.com/gothinkster/realworld