Bug: red lines and area with positive values

[aalfath]

Hello,

Thanks for creating this library!

I'm not sure if this one is a bug or not, but I tried to create a chart from the example chart with y-min and y-max and I'm not sure if the chart generates correctly.

There are some red lines and area with certainly positive values in its data.
Is this a normal behavior?

I tried to check the value of the series and it does indeed positive (more than 0)

Any help would be appreciated!

[gpbl]

Ho @aalfath indeed it seems a bug. Could you share the data you are using for the series, so that I can replicate it? Thanks!

[aalfath]

Hi @gpbl, kindly used below data:

let data: Array<Float> = [0.0,  -2.70548,  -2.63699,  3.09075,  -3.05268, 0.0, 4.44349, 1.0, 0.0, -1.30397, 0.0, 0.0, 1.64384, -3.17637, 4.92295, -1.89212, -3.44178, -4.09326, 0.0, 2.06336, -2.5, 2.74829, -4.8532, 1.4726, -2.32021, 0.0, 0.0, -4.375, 4.10663, -0.821326, -1.77233, 1.73801]

Also, I can confirm that the bug would still appear even when minY and maxY is not defined. I have edited the title to avoid misunderstanding

[gpbl]

I can replicate this behavior even with

let data: Array<Float> = [0, -2, -2, 3, -3, 4, 1, 0, -1]

It seems the zero is giving problems when calculating positive/negative lines. Fix is coming, thanks for finding this bug!

(note to myself: this line should check <= 0 not just < 0.)

[gpbl]

You can download the fixed release from https://github.com/gpbl/SwiftChart/releases/tag/v0.2.2, releasing on cocoapod soon once I remember how it works 📦 😛

[aalfath]

Thank you for the quick fix, much appreciated! 😃 👍

[gpbl]

You are welcome! please reopen if needed (couldn't test the fix heavily).