-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Bash in Api Recorder #8460
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/213428d96af92300dc4ae3abf54b8c22d92d86c8/gradio-4.33.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@213428d96af92300dc4ae3abf54b8c22d92d86c8#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-builds.s3.amazonaws.com/213428d96af92300dc4ae3abf54b8c22d92d86c8/gradio-client-0.20.1.tgz |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
…io-app/gradio into aliabd/api-recorder-changes Please enter a commit message to explain why this merge is necessary,
Thanks for taking care of this @aliabd! I like the suggestion of saving the event_id to a variable so that the snippet is completely copy-able. Could we make the regular code snippet like that as wells? I do think we should avoid |
Made the changes if you can take another look @abidlabs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @aliabd! I tweaked the code snippets so that each command appears on a separate line
but otherwise, this is working great!
Creates API recording snippets for bash like with js and python. There was a bit of a challenge given two requests are required and the event_id is needed for the second. To keep the snippet copy-paste-able without changes I opted for using jq but i'm not sure that was the right call since the user may not have it installed already. Open to removing that.
Also noticed a bug with the copy button on recording snippets. It would always just copy the last of the three languages to mount. Very weird. I fixed it in a bit of a roundabout way but it works as expected now.
closes: #8457