Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid env-var interpolation in toolchains.xml #518

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Avoid env-var interpolation in toolchains.xml #518

merged 2 commits into from
Jan 21, 2025

Conversation

bigdaz
Copy link
Member

@bigdaz bigdaz commented Jan 20, 2025

Fixes #511

bigdaz added 2 commits January 20, 2025 10:20
@bigdaz
Tidy up generation of toolchains.xml
392620b
@bigdaz
Copy the raw JDK path into toolchains.xml
faf1d7c 
Previously we were relying on Gradle to substitute JDK environment variables
in toolchains.xml. With this change, the actual path to the JDK is encoded instead.
This should avoid issues where Gradle is not able to successfully resolve the
envioronment variable.
@bigdaz bigdaz requested a review from erichaagdev January 20, 2025 17:21
@github-actions GitHub Actions
Copy link
Contributor

Job Summary for Gradle

Demo adding Build Scan® comment to PR :: successful-build-with-always-comment
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
kotlin-dsl build 8.12 ✅ Build Scan published

@bigdaz bigdaz requested review from a team and removed request for erichaagdev January 20, 2025 17:38
@github-actions GitHub Actions
Copy link
Contributor

Job Summary for Gradle

Demo adding Build Scan® comment to PR :: successful-build-with-always-comment
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
kotlin-dsl build 8.12 ✅ Build Scan published

@bigdaz bigdaz merged commit ec1d1bf into main Jan 21, 2025
125 checks passed
@bigdaz bigdaz deleted the dd/toolchains-xml branch January 21, 2025 16:44
@bigdaz bigdaz added this to the v4.3.0 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erichaagdev erichaagdev erichaagdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.3.0
Development

Successfully merging this pull request may close these issues.

setup-gradle with gradle 7.x fails to replace environment variables in toolchains.xml
2 participants
@bigdaz @erichaagdev