Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Bump clickhouse-go (added ProxyFromEnvironment support) #373

Merged
merged 1 commit into from
May 8, 2023
Merged

[2.x] Bump clickhouse-go (added ProxyFromEnvironment support) #373

merged 1 commit into from
May 8, 2023

Conversation

slvrtrn
Copy link
Contributor

@slvrtrn slvrtrn commented May 8, 2023

See ClickHouse/clickhouse-go#987

I was investigating the Grafana data source issue (Cloud cannot be accessed via proxy) that boiled down to ignored HTTP_PROXY and HTTPS_PROXY env variables in the CH data source.

Now, the underlying driver should correctly load the env settings.

@bossinc bossinc merged commit b28a879 into grafana:v2.x May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slvrtrn @bossinc