Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds headers field for CheckHealthRequest #512

Merged
merged 2 commits into from
May 31, 2022
Merged

Adds headers field for CheckHealthRequest #512

merged 2 commits into from
May 31, 2022

Conversation

marefr
Copy link
Contributor

@marefr marefr commented May 31, 2022

What this PR does / why we need it:
Adds Headers field/property for the CheckHealthRequest protobuf message/SDK struct, following how QueryDataRequest protobuf message/SDK struct is implemented.

Which issue(s) this PR fixes:
Closes #496

Special notes for your reviewer:
Might add some additional helper functions/built-in support to make it easier to work with these things and the httpclient package eventually, but will be handled separately.

@marefr marefr requested a review from a team as a code owner May 31, 2022 11:03
@marefr marefr requested review from wbrowne and removed request for a team May 31, 2022 11:03
@marefr marefr self-assigned this May 31, 2022
Copy link
Member

@wbrowne wbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

backend/convert_from_protobuf_test.go Outdated Show resolved Hide resolved
@marefr marefr merged commit f716a60 into main May 31, 2022
@marefr marefr deleted the 496_feat branch May 31, 2022 14:23
sd2k added a commit to grafana/grafana-plugin-sdk-rust that referenced this pull request May 31, 2022
sd2k added a commit to grafana/grafana-plugin-sdk-rust that referenced this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

CheckHealthRequest does not have Headers, forward-oauth impossible
2 participants