Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export arrow2 #35

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Export arrow2 #35

merged 2 commits into from
Jan 10, 2022

Conversation

toddtreece
Copy link
Member

Why

I attempted to use downcast_ref with the appropriate arrow2 types, but since my crate's arrow2 dependency didn't match the plugin SDK's arrow2 dependency, downcast_ref was failing.

frame.values().as_any().downcast_ref::<PrimitiveArray<i64>>();

What

It seems like the only solution was to export the arrow2 so that other crates can access frame values. Not sure if there's a better approach here.

@toddtreece toddtreece requested a review from sd2k January 10, 2022 03:05
Copy link
Collaborator

@sd2k sd2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bleh, bit annoying but I think you're right, it's the best way of ensuring compatibility (at least until arrow2 releases a long term 1.0). Added a suggestion for a comment to explain/suggest usage of the re-export.

src/lib.rs Show resolved Hide resolved
Co-authored-by: Ben Sully <[email protected]>
@toddtreece toddtreece merged commit 66be42e into main Jan 10, 2022
@toddtreece toddtreece deleted the toddtreece/export-arrow2 branch January 10, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants