Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(distributor): validate partition ring is kafka is enabled #14303

Merged
merged 3 commits into from
Oct 4, 2024
Merged

fix(distributor): validate partition ring is kafka is enabled #14303

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7799989
fix(distributor): Activate partition ring is kafka is enabled
cyriltovena Sep 28, 2024
2ba002d
Merge branch 'main' into distributor-fix-config-partition
cyriltovena Oct 4, 2024
74ace41
validate config when starting distributor
cyriltovena Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/loki/modules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1753,7 +1753,7 @@ func (t *Loki) initAnalytics() (services.Service, error) {

// The Ingest Partition Ring is responsible for watching the available ingesters and assigning partitions to incoming requests.
func (t *Loki) initPartitionRing() (services.Service, error) {
if !t.Cfg.Ingester.KafkaIngestion.Enabled {
if !t.Cfg.Ingester.KafkaIngestion.Enabled && !t.Cfg.Distributor.KafkaEnabled {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense but the distributor won't be able to send any data to Kafka unless the ingester is also enabled due to needing some active partitions. I wonder if we should just use a single flag to enable the kafka write path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand although it feels weird that having t.Cfg.Distributor.KafkaEnabled without t.Cfg.Ingester.KafkaIngestion.Enabled panics ? Should we validate instead ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I think we need to validate that ingestion is enabled if distributor is enabled, since they're coupled in the architecture.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, I think we want to keep both flags because we want the option to stop writing to Kafka without changing the ingesters.
But we also want a validation for All (and maybe Write) mode to enforce that the ingester is enabled if the distributor is enabled. We don't want this check for micro-services mode though, since those flags can be set explicitly on those components.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I'll add a validation. That will avoid the panic at least.

return nil, nil
}

Expand Down
Loading