chore: LogQL syntax and AST simplification and cosistency #16028
+2,497
−2,598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
force-pushed
the
chaudum/logql-syntax
branch
from
d2c047d to
0cc6d8f
Compare
The `Walk(f WalkFn)` implementation expects to first visit the current node and then invoke `Walk(f)` on all its children if they are not `nil`. This also fixes the `checkIntervalLimit(syntax.SampleExpr, time.Duration)` function, which did not visit the expression if it was a `*ConcatSampleExpr`. Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
chaudum
force-pushed
the
chaudum/logql-syntax
branch
from
0cc6d8f to
76fc4a7
Compare
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
chaudum
force-pushed
the
chaudum/logql-syntax
branch
from
76fc4a7 to
df5fb62
Compare
chaudum
commented
Feb 3, 2025
| goyacc -p $(basename $(notdir $<)) -o $@ $< | ||
| sed -i.back '/^\/\/line/ d' $@ | ||
| rm ${@}.back | ||
| goyacc -l -p $(basename $(notdir $<)) -o $@ $< |
There was a problem hiding this comment.
-l removes the line comments that are not liked by the goformat linter
| @@ -138,7 +138,7 @@ type lexer struct { | |||
| builder strings.Builder | |||
| } | |||
|
|
|||
| func (l *lexer) Lex(lval *exprSymType) int { | |||
| func (l *lexer) Lex(lval *syntaxSymType) int { | |||
There was a problem hiding this comment.
Prefix changes from expr to sytnax, because the prefix is declared by the name of the .y file, see yacc target in Makefile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This PR contains changes from #16033
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR