-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register all available Go metrics #6962
Register all available Go metrics #6962
Conversation
Adding all available metrics from Go Signed-off-by: Danny Kopping <[email protected]>
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0.1%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
- loki -0.1% |
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
- loki -0.1% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, a lot simpler. LGTM
Adding all available metrics from Go Signed-off-by: Danny Kopping <[email protected]> Signed-off-by: Danny Kopping <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-6962-to-release-2.6.x origin/release-2.6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 449dd819810a4b04731e34efbd202af9914f0e55
# Push it to GitHub
git push --set-upstream origin backport-6962-to-release-2.6.x
git switch main
# Remove the local backport branch
git branch -D backport-6962-to-release-2.6.x Then, create a pull request where the |
Adding all available metrics from Go Signed-off-by: Danny Kopping <[email protected]> Signed-off-by: Danny Kopping <[email protected]>
…grafana#6962) Adding all available metrics from Go Signed-off-by: Danny Kopping <[email protected]> Signed-off-by: Danny Kopping <[email protected]>
What this PR does / why we need it:
In the previous PR #6957 I accidentally removed about 88 metrics due to the resetting of
prometheus.Default{Gatherer,Registerer}
.This new PR simplifies the implementation by using the default registerer but unregistering the default Go collector (which contains only a stripped-down list of metrics from the go runtime) with a collector which contains all available metrics.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
The following metrics have been added:
And I have validated that no other metrics have been removed.
Checklist
CHANGELOG.md
.docs/sources/upgrading/_index.md