This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Fix string slice length bug #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the string conversion map has the right length. This bug was introduced a7e0f43. This change allocates the correct size of an array to match the highest key id in the string rewrite map.
simonswine
force-pushed
the
20220719_fix-bug-with-string-slice-length
branch
from
64ee9ea to
a54274b
Compare
cyriltovena
approved these changes
Jul 19, 2022
simonswine
added a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
…ith-string-slice-length Fix string slice length bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the string conversion map has the right length. This bug was introduced a7e0f43.
This change allocates the correct size of an array to match the highest
key id in the string rewrite map.