This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b004b9
to
67654c0
Compare
Looks promising so far |
Merged
67654c0
to
386c3da
Compare
eaf992b
to
66aa081
Compare
aae65c4
to
6ce0288
Compare
This allows to query parquet files in a local directory and/or bucket. The current implementation will load all profiles from the matching series finger prints in full, before checking if the timestamps matches.
This replaces the standard libary duration parse with the one from prometheus to allow time periods like days, weeks and years.
This allows to list local blocks
0da45c3
to
96e53bb
Compare
cyriltovena
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great work. I left mostly questions and observations. I think this is a good step forward to start benchmarking different parquet format/access model.
b481478
to
85562ec
Compare
simonswine
added a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
…-querier Add ability to query local blocks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block querier allows to query parquet files locally (and by using a BucketReader, also from a object store bucket)
The current implementation will load all profiles from the matching series finger prints in full, before checking if the timestamps matches on RowGroup or Profile level. (This is something I would like to look at outside of this PR).
This also adds a CLI
firetool
to list blocks. (I also plan on integratingparquet-tool
in it):