This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Use tempo's iterators #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
force-pushed
the
20220830_use_tempo_iters
branch
3 times, most recently
from
b700a1b to
9644a6f
Compare
cyriltovena
reviewed
Aug 31, 2022
| return exists | ||
| } | ||
|
|
||
| func (b *singleBlockQuerier) forMatchingProfiles(ctx context.Context, matchers []*labels.Matcher, start, end model.Time, |
There was a problem hiding this comment.
💡
I think this should return an iterator type. Ultimately I should be able to use that iterator to read profile data, and stacktraces samples. Ordered by ts and labels.
There was a problem hiding this comment.
In fact I think the profileSelector should be an iterator, although I just realised that merging across different block/head will cause issues if we don't properly merge symbols.
Imported from github.com/grafana/tempo/pkg/parquetquery d1fc482f4b2c1679bc2deca6055129c0168fcfb0
simonswine
force-pushed
the
20220830_use_tempo_iters
branch
from
9644a6f to
dbbe62d
Compare
simonswine
added a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
…_iters Use tempo's iterators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This imports tempo's
parquetqueryintopkgs/firedb/query. It makes use of its iterators to gather data that matches.This avoids reconstruction of data using reflection and also reuses
parquet.Valueswherever possible