This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Tooltips #216
Merged
Tooltips #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome ! |
aocenas
approved these changes
Sep 12, 2022
Closed
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
* Tooltips * Tooltip data * Tooltip design * Rename * getUnitValue * Format samples with commas for every 1000 * Update css * Move tooltip data logic into own function and cleanup * Tests * Move getTooltipData to tooltips component * Self review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tooltips to the flamegraph.
Note: we will add a context menu (referenced here) to copy the symbol name and highlight other node with the same name in another PR.