Datasource: Min step in config page #269
Conversation
| }} | ||
| /> | ||
| } | ||
| tooltip="Minimal step used for metric query. Should be the same or higher as the scrape interval setting in the Fire database." |
There was a problem hiding this comment.
@cyriltovena @simonswine does this make sense? Also in the Prometheus we call this scrape interval but from that, it's not really clear why it is needed and what is grafana using it for. So to me, it seems more clear to say this is Min interval for the query (which also, may not be clear what that actually is) and just add the tooltip saying this should be the same as scrape interval but that is sort of subjective for me so let me know what you think.
There was a problem hiding this comment.
That sounds correct to me 👍.
Maybe in the future we can like the config setting in the Fire docs there as well.
|
I think this is ready to go I have tried it for very short time scales and the graph looks a lot better now 🙂 |
Datasource: Min step in config page
Fixes: #238
Adds a min step setting in the config page of the data source. This is needed because similar to Prometheus fire has a set scrape interval and it does not make sense to try to query with a step smaller than that as there are no data points.