This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
[Helm] Load environment variables from secrets #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Lamirault <[email protected]>
simonswine
force-pushed
the
feat/env-from-secrets
branch
from
d8d9b9f to
8187145
Compare
simonswine
reviewed
Nov 3, 2022
There was a problem hiding this comment.
Thanks for your contribution!
I think the way it is, it won't work as you won't access the correct values, see my specific comment.
Other than that:
Could you please rebase with the latest main (to fix the broken tests)?(sorry I have already done that now 😂 )- If possible run
make helm/checkand commit the changed file (we really should have a CI check for that #396 )
operations/phlare/helm/phlare/templates/deployments-statefulsets.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Nicolas Lamirault <[email protected]>
simonswine
approved these changes
Nov 4, 2022
|
@simonswine any news to release a new chart version with this feature ? |
simonswine
added a commit
to simonswine/phlare
that referenced
this pull request
Nov 21, 2022
Was forgotten in grafana#393. This will release a new version.
simonswine
added a commit
to simonswine/phlare
that referenced
this pull request
Nov 21, 2022
Was forgotten in grafana#393. This will release a new version.
|
@nlamirault it has been released now https://github.com/grafana/helm-charts/releases/tag/phlare-0.1.1 I have forgotten that we need to raise the version in your original PR. Sorry about this delay and thanks for your contribution. |
|
Thanks @simonswine |
simonswine
added a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
…ecrets [Helm] Load environment variables from secrets
simonswine
added a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
Was forgotten in grafana/phlare#393. This will release a new version.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nicolas Lamirault [email protected]