Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Fixes http2 instrumentation. #439

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Fixes http2 instrumentation. #439

merged 3 commits into from
Nov 30, 2022

Conversation

cyriltovena
Copy link
Collaborator

Since #226 we lost automatic http log and metrics. This PR re-introduce it by fixing the faulty middleware (log).

Fixes #231

Since #226 we lost automatic http log and metrics. This PR re-introduce it
by fixing the faulty middleware (log).

Fixes #231
Copy link
Collaborator

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tried the metrics locally, they seem to work fine. Great work

@simonswine simonswine merged commit 1b2f3ce into main Nov 30, 2022
@simonswine simonswine deleted the fix-log-instrumentation branch November 30, 2022 16:28
simonswine added a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactivate log and metrics server instrumentation.
2 participants