-
Notifications
You must be signed in to change notification settings - Fork 73
Conversation
@cyriltovena Could you please take a look? Thanks! 💚 💙 💜 💛 ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, this is super useful to have.
I only have one request, could add the existence of that flag to the -help
output? Currently it is not mentioned at all. You could modify -target
or also register a separate flag there (or maybe even both)
Of course. Also, I noticed that phlare's current help info has some problems. like it uses the wrong name. ➜ phlare git:(main) ✗ ./main --help
Usage of config-file-loader:
-auth.multitenancy-enabled
When set to true, incoming HTTP requests must specify tenant ID in HTTP X-Scope-OrgId header. When set to false, tenant ID anonymous is used instead.
-client.tenant-id string
Tenant ID to use when pushing profiles to Phlare (default: anonymous). (default "anonymous")
-client.url value
URL of log server.
-config.expand-env
Expands ${var} in config according to the values of the environment variables. I'll fix it together. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@hi-rustin I am really sorry that it took so long. Keep pinging and eventually I will get to it 🙂. I would prefer we change the structure of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self check
@simonswine It is ready for another review. Also, I think we still have some work to do.
I can do it in my following PRs. Because it's off this topic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes fully agree with solving those problems are off-topic to this PR, it is gotten large enough already.
Thank you so much for going through the review rounds. LGTM
Thanks for your review! 💚 💙 💜 💛 ❤️ |
This adds the ability to list modules, display a basic flag `-help` and `-help-all` including all flags. And handles `-version` from the main package.
close #367
Try to add
-modules
support. Most code from mimir.