Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Improve annotations based scraping for helm #529

Merged
merged 4 commits into from
Feb 22, 2023

Conversation

cyriltovena
Copy link
Collaborator

This PR introduces annotations to configure scraping per profile type.

For example:

metadata:
  annotations:
    profiles.grafana.com/memory.scrape: "true"
    profiles.grafana.com/memory.port: "8080"
    profiles.grafana.com/cpu.scrape: "true"
    profiles.grafana.com/cpu.port: "8080"
    profiles.grafana.com/goroutine.scrape: "true"
    profiles.grafana.com/goroutine.port: "8080"

will scrape the memory, cpu and goroutine profiles from the 8080 port of the pod.

@cyriltovena
Copy link
Collaborator Author

The build is failing because we need to tag 0.5 with the new prometheus lib. But we can still merge this one.

Copy link
Collaborator

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work for me. Thanks for getting this wall of YAML in 😂

LGTM

@cyriltovena
Copy link
Collaborator Author

Thanks I'll merge and cut 0.5 :)

@cyriltovena cyriltovena merged commit 67e78c2 into main Feb 22, 2023
@cyriltovena cyriltovena deleted the scrape-config-annotations branch February 22, 2023 10:19
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
* Improve annotations based scraping for helm

* typo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants