Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Add index page #547

Merged
merged 4 commits into from
Mar 6, 2023
Merged

Conversation

Rustin170506
Copy link
Contributor

@Rustin170506 Rustin170506 commented Feb 27, 2023

close #508

It looks like:
image

@Rustin170506
Copy link
Contributor Author

@cyriltovena What kind of index I should add a link for? Do we need to list all the HTTP routes?

@Rustin170506 Rustin170506 changed the title [WIP]Add index page Add index page Feb 28, 2023
@Rustin170506 Rustin170506 marked this pull request as ready for review February 28, 2023 02:55
@cyriltovena
Copy link
Collaborator

Those could be nice:

  • /runtime_config
  • /api/swagger.json

I'd love to have statusv1.StatusServiceServer but I think this will require javascript or another handler, so this could be done in another PR.

@cyriltovena
Copy link
Collaborator

Love the work btw ! well done @hi-rustin

@Rustin170506
Copy link
Contributor Author

Those could be nice:

  • /runtime_config
  • /api/swagger.json

Added.
Thanks for your review! 💚 💙 💜 💛 ❤️

'd love to have statusv1.StatusServiceServer but I think this will require javascript or another handler, so this could be done in another PR.

I'll try to add it next PR.

Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 0898778 into grafana:main Mar 6, 2023
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
* Add index page

* Add some indexes

* Add swagger json link

* Remove new line
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an index page
2 participants